Skip to content

[RISCV] Move slide and gather costing to subtarget [NFC] #65396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[RISCV] Move slide and gather costing to subtarget [NFC] #65396

wants to merge 2 commits into from

Conversation

preames
Copy link
Collaborator

@preames preames commented Sep 5, 2023

As discussed during review of D159332. This PR doesn't actually common up that copy of the code because doing so is not NFC - due to DLEN. Fixing that will be a future PR.

@preames
[RISCV] Move slide and gather costing to subtarget [NFC]
3430862 
As discussed during review of D159332.  This PR doesn't actually
common up that copy of the code because doing so is not NFC - due to
DLEN.  Fixing that will be a future PR.
@preames preames requested a review from a team as a code owner September 5, 2023 17:45
@topperc
Copy link
Collaborator

topperc commented Sep 5, 2023

Where was this discussed in D159332?

Why do we want this in Subtarget? Seems weird to start bring InstructionCost into Subtarget.

@preames
Copy link
Collaborator Author

preames commented Sep 7, 2023

Where was this discussed in D159332?
"Discussed" was the wrong word. It was one of the TODOs which had gone without discussion.

Why do we want this in Subtarget? Seems weird to start bring InstructionCost into Subtarget.
We talked offline, and both felt subtarget wasn't the right place for this. We were tentatively thinking putting this on TLI. Is that still what you're thinking?

@topperc
Copy link
Collaborator

topperc commented Sep 7, 2023

Where was this discussed in D159332?
"Discussed" was the wrong word. It was one of the TODOs which had gone without discussion.
Why do we want this in Subtarget? Seems weird to start bring InstructionCost into Subtarget.
We talked offline, and both felt subtarget wasn't the right place for this. We were tentatively thinking putting this on TLI. Is that still what you're thinking?

Yes. That's the best place I can think of right now.

topperc
topperc approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

preames added a commit that referenced this pull request Sep 8, 2023
@preames
[RISCV] Move slide and gather costing to TLI [NFC] (PR #65396)
463c9f4 
As mentioned in TODOs from D159332.  This PR doesn't actually
common up that copy of the code because doing so is not NFC - due to
DLEN.  Fixing that will be a future PR.
@preames
Copy link
Collaborator Author

preames commented Sep 8, 2023

Landed as:

commit 463c9f44dcd8a7a6e056cf3fd0a92ca42c8c6155 (HEAD -> main, upstream/main, upstream/HEAD)
Author: Philip Reames <preames@rivosinc.com>
Date:   Thu Sep 7 16:08:47 2023 -0700

    [RISCV] Move slide and gather costing to TLI [NFC] (PR #65396)
    
    As mentioned in TODOs from D159332.  This PR doesn't actually
    common up that copy of the code because doing so is not NFC - due to
    DLEN.  Fixing that will be a future PR.

@preames preames closed this Sep 8, 2023
@preames preames deleted the pr-2023-09-05-1 branch September 8, 2023 14:34
@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topperc topperc topperc approved these changes

Assignees
No one assigned
Labels
backend:RISC-V
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preames @topperc